Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

fix(RAG): Fix RAG support for taxonomies with compositional skills (backport #3060)#3147

Merged
courtneypacheco merged 1 commit intorelease-v0.23instructlab/instructlab:release-v0.23from
mergify/bp/release-v0.23/pr-3060instructlab/instructlab:mergify/bp/release-v0.23/pr-3060Copy head branch name to clipboard
Feb 17, 2025
Merged

fix(RAG): Fix RAG support for taxonomies with compositional skills (backport #3060)#3147
courtneypacheco merged 1 commit intorelease-v0.23instructlab/instructlab:release-v0.23from
mergify/bp/release-v0.23/pr-3060instructlab/instructlab:mergify/bp/release-v0.23/pr-3060Copy head branch name to clipboard

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Feb 17, 2025

This fixes a bug in RAG convert that causes it to fail on taxonomies that have compositional skills. The correct behavior is to ignore the compositional skills because they have no documents, but instead this was crashing when it encountered them. This PR also adds a compositional skill to the sample test taxonomy, which would have let us catch this bug.

Issue resolved by this Pull Request:
Resolves #3008

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.
This is an automatic backport of pull request #3060 done by [Mergify](https://mergify.com).

@mergify mergify bot mentioned this pull request Feb 17, 2025
Merged
6 tasks
@mergify mergify bot added testing Relates to testing release-branch Pull Request directly to a release branch ci-failure PR has at least one CI failure labels Feb 17, 2025
@jwm4 @courtneypacheco
fix(RAG): Fix RAG support for taxonomies with compositional skills
1cc3606 
Signed-off-by: Bill Murdock <bmurdock@redhat.com>
(cherry picked from commit 8f65ae6)
@courtneypacheco courtneypacheco force-pushed the mergify/bp/release-v0.23/pr-3060 branch from ed1f36e to 1cc3606 Compare February 17, 2025 20:08
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Feb 17, 2025
@courtneypacheco courtneypacheco requested review from a team, cdoern and danmcp February 17, 2025 20:56
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Feb 17, 2025
@courtneypacheco courtneypacheco merged commit 4ca08ff into release-v0.23 Feb 17, 2025
27 checks passed
@courtneypacheco courtneypacheco deleted the mergify/bp/release-v0.23/pr-3060 branch February 17, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danmcp danmcp Awaiting requested review from danmcp

@cdoern cdoern Awaiting requested review from cdoern

1 more reviewer

@courtneypacheco courtneypacheco courtneypacheco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

one-approval PR has one approval from a maintainer release-branch Pull Request directly to a release branch testing Relates to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@courtneypacheco @jwm4
Morty Proxy This is a proxified and sanitized view of the page, visit original site.