deps: cap dependencies for 0.23.0 release#3015
deps: cap dependencies for 0.23.0 release#3015mergify[bot] merged 1 commit intoinstructlab:release-v0.23instructlab/instructlab:release-v0.23from
Conversation
Signed-off-by: Charlie Doern <cdoern@redhat.com>
|
@cdoern just for my understanding: why do we cap some but not all instructlab-* dependencies? |
|
@booxter we only cap the "main" libraries (SDG, Train, Eval) typically. |
|
E2E (NVIDIA L40S x4) workflow launched on this PR: View run |
|
@cdoern ack but whatever the reasoning behind the cap, it probably applies to other instructlab- libraries, no? (The reasoning I assume is - we don't want to be broken by a later library release. I am not necessarily convinced this is good, but I'm not questioning it here.) |
|
That reasoning is correct - I think typically, the reason we haven't capped the other libraries is that they don't get bumped at all (or ever, in the case of |
|
The way I see it: either these other libraries get bumped, and then we probably want to be guarded against them too; or they don't get bumped, and then a probable cap would not be an issue anyway. So while capping more active libraries is more pressing, capping the rest would be at worst a no-op. |
|
e2e workflow succeeded on this PR: View run, congrats! |
Checklist:
conventional commits.