Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

update the train test result#2863

Merged
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
reidliu41:update-train-test-resultreidliu41/instructlab:update-train-test-resultCopy head branch name to clipboard
Jan 7, 2025
Merged

update the train test result#2863
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
reidliu41:update-train-test-resultreidliu41/instructlab:update-train-test-resultCopy head branch name to clipboard

Conversation

@reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Jan 7, 2025

For #2741 (comment)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@mergify mergify bot added the ci-failure PR has at least one CI failure label Jan 7, 2025
@reidliu41 reidliu41 force-pushed the update-train-test-result branch from 78c06b8 to 2376c2b Compare January 7, 2025 01:21
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Jan 7, 2025
@reidliu41 reidliu41 force-pushed the update-train-test-result branch from b8c5aff to bac8e14 Compare January 7, 2025 01:25
@mergify mergify bot added the ci-failure PR has at least one CI failure label Jan 7, 2025
@reidliu41
Copy link
Contributor Author

reidliu41 commented Jan 7, 2025 

  mypy: commands[0]> mypy
  Error: src/instructlab/utils.py:236: error: Argument 1 to "is_taxonomy_file" has incompatible type "str | None"; expected "str"  [arg-type]
  Error: src/instructlab/utils.py:240: error: Incompatible return value type (got "list[str | None]", expected "list[str]")  [return-value]

@nathan-weinberg
Copy link
Member

nathan-weinberg commented Jan 7, 2025

@Mergifyio rebase

@reidliu41 @nathan-weinberg
update the train test result
c5408ed 
Signed-off-by: reid_liu <guliu@redhat.com>
@mergify
Copy link
Contributor

mergify bot commented Jan 7, 2025

rebase

✅ Branch has been successfully rebased

@nathan-weinberg nathan-weinberg force-pushed the update-train-test-result branch from bac8e14 to c5408ed Compare January 7, 2025 14:55
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Jan 7, 2025
@github-actions
Copy link

github-actions bot commented Jan 7, 2025

E2E (NVIDIA L40S x4) workflow launched on this PR: View run

@nathan-weinberg nathan-weinberg self-requested a review January 7, 2025 15:38
@nathan-weinberg nathan-weinberg mentioned this pull request Jan 7, 2025
Merged
6 tasks
@nathan-weinberg nathan-weinberg requested a review from cdoern January 7, 2025 16:56
cdoern
cdoern approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@cdoern cdoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e job looks like it got past the point of failure, LGTM

@mergify mergify bot added the one-approval PR has one approval from a maintainer label Jan 7, 2025
@github-actions
Copy link

github-actions bot commented Jan 7, 2025

e2e workflow succeeded on this PR: View run, congrats!

bbrowning
bbrowning approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@bbrowning bbrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks!

@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Jan 7, 2025
@mergify mergify bot merged commit 96623a7 into instructlab:main Jan 7, 2025
29 checks passed
@nathan-weinberg nathan-weinberg mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@bbrowning bbrowning bbrowning approved these changes

@cdoern cdoern cdoern approved these changes

@nathan-weinberg nathan-weinberg nathan-weinberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reidliu41 @nathan-weinberg @bbrowning @cdoern
Morty Proxy This is a proxified and sanitized view of the page, visit original site.