Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

fix the warning when the model is a file type#2854

Merged
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
reidliu41:fix-the-backend-warningreidliu41/instructlab:fix-the-backend-warningCopy head branch name to clipboard
Jan 10, 2025
Merged

fix the warning when the model is a file type#2854
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
reidliu41:fix-the-backend-warningreidliu41/instructlab:fix-the-backend-warningCopy head branch name to clipboard

Conversation

@reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Jan 5, 2025 •
edited
Loading

Issue resolved by this Pull Request:
Resolves #2853

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@mergify mergify bot added the ci-failure PR has at least one CI failure label Jan 5, 2025
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Jan 6, 2025
@reidliu41
fix the warning when the model is a file type
6d01501 
Signed-off-by: reid_liu <guliu@redhat.com>
@reidliu41 reidliu41 force-pushed the fix-the-backend-warning branch from 6b876ba to 6d01501 Compare January 7, 2025 22:57
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Jan 7, 2025
@cdoern cdoern added the hold In-progress PR. Tag should be removed before merge. label Jan 7, 2025
@cdoern
Copy link
Contributor

cdoern commented Jan 7, 2025

we need to get in #2825 first (will be in soon)

@reidliu41
Copy link
Contributor Author

reidliu41 commented Jan 7, 2025

sure

@cdoern cdoern removed the hold In-progress PR. Tag should be removed before merge. label Jan 8, 2025
@ktam3 ktam3 linked an issue Jan 8, 2025 that may be closed by this pull request
it always hit the warning without tokenizer_config.json for the model file #2853
Closed
@mergify mergify bot merged commit 2e21014 into instructlab:main Jan 10, 2025
27 checks passed
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cdoern cdoern cdoern approved these changes

@nathan-weinberg nathan-weinberg nathan-weinberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

it always hit the warning without tokenizer_config.json for the model file

3 participants

@reidliu41 @cdoern @nathan-weinberg
Morty Proxy This is a proxified and sanitized view of the page, visit original site.