Add legacy template override option to general config#2789
Merged
mergify[bot] merged 2 commits intoinstructlab:maininstructlab/instructlab:mainfrom Dec 13, 2024
Merged
Add legacy template override option to general config#2789mergify[bot] merged 2 commits intoinstructlab:maininstructlab/instructlab:mainfrom
mergify[bot] merged 2 commits intoinstructlab:maininstructlab/instructlab:mainfrom
Conversation
Signed-off-by: Mustafa Eyceoz <meyceoz@redhat.com>
Signed-off-by: Mustafa Eyceoz <meyceoz@redhat.com>
751536d to
3cb5d7f
Compare
cdoern
reviewed
Dec 13, 2024
cdoern
approved these changes
Dec 13, 2024
Contributor
cdoern
left a comment
There was a problem hiding this comment.
I took a look at the clickext code, I think it's fair to merge this as is but scope work to funnel a single "top level" config option into multiple commands. That seems outside the scope of this PR though, so let's just take this as is.
alinaryan
approved these changes
Dec 13, 2024
Contributor
|
@Mergifyio backport release-v0.22 |
Contributor
✅ Backports have been createdDetails
|
6 tasks
mergify bot
added a commit
that referenced
this pull request
Dec 13, 2024
#2794) Adds option to select legacy template in the general section of the config. Solves #2790 **Checklist:** - [ ] **Commit Message Formatting**: Commit titles and messages follow guidelines in the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary). - [ ] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release. - [ ] Documentation has been updated, if necessary. - [ ] Unit tests have been added, if necessary. - [ ] Functional tests have been added, if necessary. - [ ] E2E Workflow tests have been added, if necessary. <hr>This is an automatic backport of pull request #2789 done by [Mergify](https://mergify.com). Approved-by: cdoern Approved-by: alinaryan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds option to select legacy template in the general section of the config.
Solves #2790
Checklist:
conventional commits.