Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

add a message for download#2716

Merged
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
reidliu41:add-success-msg-for-downloadreidliu41/instructlab:add-success-msg-for-downloadCopy head branch name to clipboard
Jan 21, 2025
Merged

add a message for download#2716
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
reidliu41:add-success-msg-for-downloadreidliu41/instructlab:add-success-msg-for-downloadCopy head branch name to clipboard

Conversation

@reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Nov 28, 2024 •
edited
Loading

  • 2651 add success message for download and print the model list after download
$ ilab model download --hf-token test
Downloading model from Hugging Face:
    Model: instructlab/granite-7b-lab-GGUF@main
    Destination: /Users/xx/.cache/instructlab/models

ᕦ(òᴗóˇ)ᕤ instructlab/granite-7b-lab-GGUF model download completed successfully! ᕦ(òᴗóˇ)ᕤ

Downloading model from Hugging Face:
    Model: instructlab/merlinite-7b-lab-GGUF@main
    Destination: /Users/xx/.cache/instructlab/models

ᕦ(òᴗóˇ)ᕤ instructlab/merlinite-7b-lab-GGUF model download completed successfully! ᕦ(òᴗóˇ)ᕤ

Downloading model from Hugging Face:
    Model: TheBloke/Mistral-7B-Instruct-v0.2-GGUF@main
    Destination: /Users/xx/.cache/instructlab/models

ᕦ(òᴗóˇ)ᕤ TheBloke/Mistral-7B-Instruct-v0.2-GGUF model download completed successfully! ᕦ(òᴗóˇ)ᕤ

Available models (`ilab model list`):
+--------------------------------------+---------------------+---------+
| Model Name                           | Last Modified       | Size    |
+--------------------------------------+---------------------+---------+
| prometheus-eval/prometheus-8x7b-v2.0 | 2024-11-06 16:16:09 | 87.0 GB |
| instructlab/granite-7b-lab           | 2024-11-06 14:39:06 | 12.6 GB |
| merlinite-7b-lab-Q4_K_M.gguf         | 2024-09-14 06:45:33 | 4.1 GB  |
| mistral-7b-instruct-v0.2.Q4_K_M.gguf | 2024-11-06 16:58:49 | 4.1 GB  |
| granite-7b-lab-Q4_K_M.gguf           | 2024-11-28 00:39:47 | 3.8 GB  |
+--------------------------------------+---------------------+---------+

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@mergify mergify bot added the testing Relates to testing label Nov 28, 2024
@reidliu41 reidliu41 force-pushed the add-success-msg-for-download branch from 37b4532 to 1baf3fb Compare November 28, 2024 09:35
@mergify mergify bot added the ci-failure PR has at least one CI failure label Nov 28, 2024
@reidliu41 reidliu41 force-pushed the add-success-msg-for-download branch from 1baf3fb to fcfff78 Compare November 28, 2024 12:07
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Nov 28, 2024
jaideepr97
jaideepr97 reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@jaideepr97 jaideepr97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @reidliu41

src/instructlab/model/download.py Outdated

try:
downloader.download()
click.echo(f"\n✅ {repository} model download completed successfully!\n")
Copy link
Contributor

@jaideepr97 jaideepr97 Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to use downloader.repository here for consistency

Copy link
Contributor Author

@reidliu41 reidliu41 Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your remind.. updated. @jaideepr97

@mergify mergify bot added the ci-failure PR has at least one CI failure label Nov 28, 2024
@reidliu41 reidliu41 force-pushed the add-success-msg-for-download branch from 9d2d04a to 6d2c65e Compare November 28, 2024 22:50
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Nov 28, 2024
@reidliu41 reidliu41 force-pushed the add-success-msg-for-download branch from 97c7ad0 to 88c5d3c Compare November 28, 2024 22:53
@reidliu41 reidliu41 requested a review from jaideepr97 November 29, 2024 00:35
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Nov 29, 2024
@cdoern cdoern self-requested a review December 1, 2024 04:32
@cdoern
Copy link
Contributor

cdoern commented Dec 1, 2024

will this render properly on all OS?

Also, are emojis a thing we want to introduce as a consistent part of the user experience of instructlab?

I think this looks nice, but if we do this here then we should be using these everywhere I would think to show success

@nathan-weinberg nathan-weinberg linked an issue Dec 1, 2024 that may be closed by this pull request
Add Confirmation and Next Steps for Model Download Command (ilab model download) #2651
Closed
@JustinXHale
Copy link

JustinXHale commented Dec 2, 2024

will this render properly on all OS?

Also, are emojis a thing we want to introduce as a consistent part of the user experience of instructlab?

I think this looks nice, but if we do this here then we should be using these everywhere I would think to show success

Agree @cdoern we should be consistent across the CLI.
@reidliu41 this looks great

@reidliu41
Copy link
Contributor Author

reidliu41 commented Dec 3, 2024

Thank you so much for feedback. I think is ok to add to others one by one later on..

@reidliu41 reidliu41 mentioned this pull request Dec 4, 2024
Closed
@reidliu41
Copy link
Contributor Author

reidliu41 commented Dec 4, 2024

2741

@ktam3 ktam3 removed a link to an issue Dec 9, 2024
Add Confirmation and Next Steps for Model Download Command (ilab model download) #2651
Closed
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Dec 10, 2024
@reidliu41
add a success download message
afa28e2 
Signed-off-by: reid_liu <guliu@redhat.com>
@reidliu41 reidliu41 force-pushed the add-success-msg-for-download branch from 88c5d3c to afa28e2 Compare January 8, 2025 08:17
@reidliu41
Copy link
Contributor Author

reidliu41 commented Jan 8, 2025

Since other subcommands output merge, so updated for download

@github-actions
Copy link

github-actions bot commented Jan 8, 2025

E2E (NVIDIA L40S x4) workflow launched on this PR: View run

@github-actions
Copy link

github-actions bot commented Jan 8, 2025

e2e workflow succeeded on this PR: View run, congrats!

@reidliu41 reidliu41 removed the request for review from cdoern January 18, 2025 07:05
@reidliu41
Copy link
Contributor Author

reidliu41 commented Jan 18, 2025

@jaideepr97 sorry , could you help to re-approve again? thanks

@reidliu41 reidliu41 removed the request for review from jaideepr97 January 21, 2025 13:51
@mergify mergify bot merged commit 65d3783 into instructlab:main Jan 21, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@courtneypacheco courtneypacheco courtneypacheco approved these changes

@jaideepr97 jaideepr97 jaideepr97 approved these changes

@nathan-weinberg nathan-weinberg nathan-weinberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testing Relates to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@reidliu41 @cdoern @JustinXHale @courtneypacheco @jaideepr97 @nathan-weinberg
Morty Proxy This is a proxified and sanitized view of the page, visit original site.