Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: allow MTBenchBranchEvaluator to return a 2 or 3 sized tuple#2330

Merged
nathan-weinberg merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
alimaredia:mt-bench-branch-variable-tuple-returnalimaredia/instructlab:mt-bench-branch-variable-tuple-returnCopy head branch name to clipboard
Sep 27, 2024
Merged

fix: allow MTBenchBranchEvaluator to return a 2 or 3 sized tuple#2330
nathan-weinberg merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
alimaredia:mt-bench-branch-variable-tuple-returnalimaredia/instructlab:mt-bench-branch-variable-tuple-returnCopy head branch name to clipboard

Conversation

@alimaredia
Copy link
Contributor

@alimaredia alimaredia commented Sep 27, 2024

This commit is in preparation of a commit to the eval library [1] that returns the overall score from MT-Bench-Branch judgement.

[1] instructlab/eval#138

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@mergify mergify bot added one-approval PR has one approval from a maintainer ci-failure PR has at least one CI failure labels Sep 27, 2024
@danmcp
Copy link
Contributor

danmcp commented Sep 27, 2024

@Mergifyio rebase

This commit is in preparation of a commit to the
eval library [1] that returns the overall score
from MT-Bench-Branch judgement.

[1] instructlab/eval#138

Signed-off-by: Ali Maredia <amaredia@redhat.com>
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2024

rebase

✅ Branch has been successfully rebased

@danmcp danmcp force-pushed the mt-bench-branch-variable-tuple-return branch from b210738 to 27f84e2 Compare September 27, 2024 17:47
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Sep 27, 2024
src/instructlab/model/evaluate.py Show resolved Hide resolved
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Sep 27, 2024
@nathan-weinberg nathan-weinberg merged commit 897b431 into instructlab:main Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.