fix: remove --version from subcommands#1359
Merged
nathan-weinberg merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom Jun 14, 2024
leseb:rm-version-sub-commandsleseb/instructlab:rm-version-sub-commandsCopy head branch name to clipboard
Merged
fix: remove --version from subcommands#1359nathan-weinberg merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom leseb:rm-version-sub-commandsleseb/instructlab:rm-version-sub-commandsCopy head branch name to clipboard
nathan-weinberg merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
leseb:rm-version-sub-commandsleseb/instructlab:rm-version-sub-commandsCopy head branch name to clipboard
Conversation
The `--version` should be a root option. There is no need to print it in subsequent subcommands. For instance, it used to be printed here: ``` $ ilab config --help Usage: ilab config [OPTIONS] COMMAND [ARGS]... Command Group for Interacting with the Config of InstructLab. If this is your first time running ilab, it's best to start with `ilab init` to create the environment. Options: --version Show the version and exit. --help Show this message and exit. ``` We only need `ilab --version`. Signed-off-by: Sébastien Han <seb@redhat.com>
nathan-weinberg
approved these changes
Jun 14, 2024
cdoern
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--versionshould be a root option. There is no need to print it in subsequent subcommands.For instance, it used to be printed here:
We only need
ilab --version.Checklist:
conventional commits.