Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

[Docs] Updating docs throughout InstructLab repo per CLI redesign#1352

Merged
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
kelbrown20:update-docs-per-new-clikelbrown20/kelly-instructlab:update-docs-per-new-cliCopy head branch name to clipboard
Jun 24, 2024
Merged

[Docs] Updating docs throughout InstructLab repo per CLI redesign#1352
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
kelbrown20:update-docs-per-new-clikelbrown20/kelly-instructlab:update-docs-per-new-cliCopy head branch name to clipboard

Conversation

@kelbrown20
Copy link
Contributor

@kelbrown20 kelbrown20 commented Jun 13, 2024

Description: This PR updates documentation throughout the InstructLab repo per the redesign of the ilab CLI in #990

Issue: #1331

@mergify mergify bot added documentation Improvements or additions to documentation ci-failure PR has at least one CI failure labels Jun 13, 2024
@kelbrown20 kelbrown20 force-pushed the update-docs-per-new-cli branch 4 times, most recently from 954a3d7 to 1701f05 Compare June 13, 2024 15:24
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Jun 13, 2024
@kelbrown20 kelbrown20 force-pushed the update-docs-per-new-cli branch from 1701f05 to 3625973 Compare June 13, 2024 15:31
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Jun 13, 2024
@nathan-weinberg nathan-weinberg linked an issue Jun 14, 2024 that may be closed by this pull request
Change command usage throughout docs and code to new style #1331
Closed
@kelbrown20 kelbrown20 force-pushed the update-docs-per-new-cli branch from 3625973 to 95f9062 Compare June 14, 2024 18:48
@mergify mergify bot added CI/CD Affects CI/CD configuration and removed ci-failure PR has at least one CI failure labels Jun 14, 2024
@kelbrown20 kelbrown20 marked this pull request as ready for review June 14, 2024 18:49
cdoern
cdoern reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@cdoern cdoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one thing to check on for the aliases

README.md Outdated Show resolved Hide resolved
@kelbrown20 kelbrown20 force-pushed the update-docs-per-new-cli branch from 95f9062 to e158300 Compare June 14, 2024 19:57
drpaneas
drpaneas reviewed Jun 16, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@kelbrown20 kelbrown20 force-pushed the update-docs-per-new-cli branch from e158300 to 7794af4 Compare June 17, 2024 14:29
nathan-weinberg
nathan-weinberg suggested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@nathan-weinberg nathan-weinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo otherwise LGTM

README.md Outdated Show resolved Hide resolved
@kelbrown20 kelbrown20 force-pushed the update-docs-per-new-cli branch from 7794af4 to 26fd943 Compare June 17, 2024 17:14
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Jun 17, 2024
@kelbrown20 kelbrown20 force-pushed the update-docs-per-new-cli branch from 26fd943 to 013fd58 Compare June 17, 2024 17:46
@kelbrown20 kelbrown20 force-pushed the update-docs-per-new-cli branch from 013fd58 to 8c10e6e Compare June 17, 2024 17:49
@mergify mergify bot added ci-failure PR has at least one CI failure and removed one-approval PR has one approval from a maintainer labels Jun 17, 2024
@kelbrown20 kelbrown20 force-pushed the update-docs-per-new-cli branch from 8c10e6e to 4a3cdbb Compare June 17, 2024 17:50
@kelbrown20 kelbrown20 force-pushed the update-docs-per-new-cli branch from 4a3cdbb to 8502c71 Compare June 17, 2024 17:51
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Jun 17, 2024
russellb
russellb suggested changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

Just some minor issues in comments

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/cli_reference.md Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Jun 18, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @kelbrown20 please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase This Pull Request needs to be rebased label Jun 18, 2024
@kelbrown20 kelbrown20 force-pushed the update-docs-per-new-cli branch 2 times, most recently from d6a2add to 089edca Compare June 24, 2024 14:13
@mergify mergify bot removed the needs-rebase This Pull Request needs to be rebased label Jun 24, 2024
@kelbrown20 kelbrown20 mentioned this pull request Jun 24, 2024
Closed
russellb
russellb suggested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted one more thing to fix

docs/workflow.puml Outdated Show resolved Hide resolved
@mergify mergify bot added the ci-failure PR has at least one CI failure label Jun 24, 2024
@kelbrown20
Updating docs throughout InstructLab repo per CLI redesign
417fc2f 
Signed-off-by: Kelly Brown <kelbrown@redhat.com>
@kelbrown20 kelbrown20 force-pushed the update-docs-per-new-cli branch from 980a31c to 417fc2f Compare June 24, 2024 19:53
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Jun 24, 2024
russellb
russellb approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mergify mergify bot added the one-approval PR has one approval from a maintainer label Jun 24, 2024
@mergify mergify bot merged commit 6a8b499 into instructlab:main Jun 24, 2024
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@drpaneas drpaneas drpaneas left review comments

@cdoern cdoern cdoern left review comments

@russellb russellb russellb approved these changes

@nathan-weinberg nathan-weinberg nathan-weinberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI/CD Affects CI/CD configuration documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change command usage throughout docs and code to new style

5 participants

@kelbrown20 @russellb @drpaneas @cdoern @nathan-weinberg
Morty Proxy This is a proxified and sanitized view of the page, visit original site.