Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

refact: rename src/instructlab/configuration/ to src/instructlab/config/#1348

Merged
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
leseb:fix-1332leseb/instructlab:fix-1332Copy head branch name to clipboard
Jun 13, 2024
Merged

refact: rename src/instructlab/configuration/ to src/instructlab/config/#1348
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
leseb:fix-1332leseb/instructlab:fix-1332Copy head branch name to clipboard

Conversation

@leseb
Copy link
Contributor

@leseb leseb commented Jun 13, 2024 •
edited
Loading

This is a follow-up to #990.

This PR created a directory - src/instructlab/configuration/, but it would be more consistent with other new directories if it was called src/instructlab/config/.

Closes: #1332

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@mergify mergify bot added the ci-failure PR has at least one CI failure label Jun 13, 2024
@mergify mergify bot added testing Relates to testing ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Jun 13, 2024
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Jun 13, 2024
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Jun 13, 2024
@leseb
refact: rename src/instructlab/configuration/ to src/instructlab/config/
2aedd61 
This is a follow-up to instructlab#990.

This PR created a directory - src/instructlab/configuration/, but it would be
more consistent with other new directories if it was called
src/instructlab/config/.

Closes: instructlab#1332
Signed-off-by: Sébastien Han <seb@redhat.com>
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Jun 13, 2024
@leseb leseb requested review from cdoern and russellb June 13, 2024 12:00
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Jun 13, 2024
@leseb leseb requested a review from nathan-weinberg June 13, 2024 14:20
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Jun 13, 2024
@leseb leseb removed the request for review from cdoern June 13, 2024 14:49
@mergify mergify bot merged commit 16011c7 into instructlab:main Jun 13, 2024
@leseb leseb deleted the fix-1332 branch June 13, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@russellb russellb russellb approved these changes

@nathan-weinberg nathan-weinberg nathan-weinberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testing Relates to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename src/instructlab/configuration/ to src/instructlab/config/

3 participants

@leseb @russellb @nathan-weinberg
Morty Proxy This is a proxified and sanitized view of the page, visit original site.