fix ilab chat run /h command failed issue#1237
Merged
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom May 31, 2024
Merged
fix ilab chat run /h command failed issue#1237mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
Conversation
leseb
suggested changes
May 31, 2024
Contributor
leseb
left a comment
There was a problem hiding this comment.
Looks good, please update your commit message body with the same content as the PR. (chat.py: def _handle_help(slef) missed one parameter even it does not use it. Update to def _handle_help(self, _))
Thanks!
leseb
reviewed
May 31, 2024
Contributor
leseb
left a comment
There was a problem hiding this comment.
Small typo in the commit:
def _handle_help(slef) should be def _handle_help(self)
…oes not use it. Update to def _handle_help(self, _) Signed-off-by: degaochu <degaochu@cn.ibm.com>
leseb
approved these changes
May 31, 2024
nathan-weinberg
approved these changes
May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Which issue is resolved by this Pull Request:
Resolves ##1236
Description of your changes:
chat.py: def _handle_help(slef) missed one parameter even it does not use it. Update to def _handle_help(self, _)