Move AWS_REGION from using secret to var#191
Merged
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom Dec 6, 2024
Merged
Move AWS_REGION from using secret to var#191mergify[bot] merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom
Conversation
Signed-off-by: Dan McPherson <dmcphers@redhat.com>
alimaredia
approved these changes
Dec 4, 2024
nathan-weinberg
approved these changes
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching from using AWS_REGION as a secret to a var. There isn't a strong reason to hide the value. And having the secret exist makes it impossible to pass the value to scripts within workflows. If the secret exists, the variable's value will still be hidden.