feat: use custom http_client#163
Merged
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom Oct 31, 2024
Merged
feat: use custom http_client#163mergify[bot] merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom
Conversation
2b8c46a to
d11a178
Compare
d11a178 to
252238b
Compare
nathan-weinberg
approved these changes
Oct 30, 2024
Member
nathan-weinberg
left a comment
There was a problem hiding this comment.
Code LGTM, passing CI, and we are already installing httpx-0.27.2 so no issues with a new dependency - thanks for the contribution @leseb!
danmcp
reviewed
Oct 30, 2024
252238b to
26cc668
Compare
This commit adds the ability to pass a custom HTTP client to the MT-Bench evaluator. This is handy when using custom certificates when interacting with the judge model serving endpoint. Signed-off-by: Sébastien Han <seb@redhat.com>
26cc668 to
010ff8c
Compare
danmcp
approved these changes
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
252238b feat: use custom http_client
commit 252238b
Author: Sébastien Han seb@redhat.com
Date: Tue Oct 29 17:56:26 2024 +0100