Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

ci: use org variable for AWS EC2 AMI in E2E CI jobs#159

Merged
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom
nathan-weinberg:aminathan-weinberg/eval:amiCopy head branch name to clipboard
Oct 25, 2024
Merged

ci: use org variable for AWS EC2 AMI in E2E CI jobs#159
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom
nathan-weinberg:aminathan-weinberg/eval:amiCopy head branch name to clipboard

Conversation

@nathan-weinberg
Copy link
Member

@nathan-weinberg nathan-weinberg commented Oct 24, 2024

This will allow us to do the following:

  1. Keep the AMI consistent across all of InstructLab
  2. Allow for updating the AMI without having to make a code change

@nathan-weinberg
ci: use org variable for AWS EC2 AMI in E2E CI jobs
8610b06 
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@nathan-weinberg nathan-weinberg requested review from a team, danmcp and n1hility October 24, 2024 17:02
@mergify mergify bot added the CI/CD Affects CI/CD configuration label Oct 24, 2024
@mergify mergify bot added the one-approval label Oct 24, 2024
danmcp
danmcp reviewed Oct 24, 2024
View reviewed changes
.github/workflows/e2e-nvidia-a10g-x1.yml Show resolved Hide resolved
@mergify mergify bot removed the one-approval label Oct 24, 2024
@nathan-weinberg nathan-weinberg removed the request for review from n1hility October 25, 2024 02:39
@mergify mergify bot merged commit a96cd75 into instructlab:main Oct 25, 2024
@nathan-weinberg nathan-weinberg deleted the ami branch October 25, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@danmcp danmcp danmcp approved these changes

@alimaredia alimaredia alimaredia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI/CD Affects CI/CD configuration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nathan-weinberg @danmcp @alimaredia

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.