Remove task logic with lm_eval 0.4.4 for agg_score#143
Merged
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom Oct 1, 2024
Merged
Remove task logic with lm_eval 0.4.4 for agg_score#143mergify[bot] merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom
Conversation
lm_eval used to return an extra entry that corresponded to the tasks requested. Ex: mmlu_pr. As of 0.4.4 the entries are now the same whether the tasks are custom are not and the extra entry is removed. So the agg score now needs to be calculated from the individual task scores returned so the logic can be shared with mmluevaluator. Signed-off-by: Dan McPherson <dmcphers@redhat.com>
alimaredia
approved these changes
Oct 1, 2024
nathan-weinberg
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lm_eval used to return an extra entry that corresponded to the tasks requested. Ex: mmlu_pr. As of 0.4.4 the entries are now the same whether the tasks are custom are not and the extra entry is removed. So the agg score now needs to be calculated from the individual task scores returned so the logic can be shared with mmluevaluator.
Without this change, the overall_score for mmlu_branch is being returned as 0.0 with lm_eval 0.4.4