Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

CI: Fix working directories to be relative#120

Merged
nathan-weinberg merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom
danmcp:e2edanmcp/eval:e2eCopy head branch name to clipboard
Aug 30, 2024
Merged

CI: Fix working directories to be relative#120
nathan-weinberg merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom
danmcp:e2edanmcp/eval:e2eCopy head branch name to clipboard

Conversation

@danmcp
Copy link
Contributor

@danmcp danmcp commented Aug 30, 2024

This should get PR validation back to a working state. Unfortunately it has to merge before it will take effect.

@mergify mergify bot added CI/CD Affects CI/CD configuration ci-failure labels Aug 30, 2024
@danmcp danmcp changed the title Fix working directories to be relative CI: Fix working directories to be relative Aug 30, 2024
Copy link
Member

@nathan-weinberg nathan-weinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits but otherwise LGTM

.github/workflows/e2e-nvidia-t4-x1.yml Outdated Show resolved Hide resolved
.github/workflows/e2e-nvidia-t4-x1.yml Outdated Show resolved Hide resolved
Signed-off-by: Dan McPherson <dmcphers@redhat.com>
@nathan-weinberg
Copy link
Member

Merging manually since CI needs this fix to pass

@nathan-weinberg nathan-weinberg merged commit 2351153 into instructlab:main Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Affects CI/CD configuration ci-failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.