Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

ci: move E2E runner from github to AWS#118

Merged
nathan-weinberg merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom
nathan-weinberg:aws-runnernathan-weinberg/eval:aws-runnerCopy head branch name to clipboard
Aug 29, 2024
Merged

ci: move E2E runner from github to AWS#118
nathan-weinberg merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom
nathan-weinberg:aws-runnernathan-weinberg/eval:aws-runnerCopy head branch name to clipboard

Conversation

@nathan-weinberg
Copy link
Member

Resolves #104

Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@nathan-weinberg nathan-weinberg requested review from a team and RobotSail August 29, 2024 12:52
@mergify mergify bot added the CI/CD Affects CI/CD configuration label Aug 29, 2024
@alimaredia
Copy link
Contributor

@nathan-weinberg can you send a run triggered by hand that shows that these new runners work?

@nathan-weinberg
Copy link
Member Author

@nathan-weinberg can you send a run triggered by hand that shows that these new runners work?

I have no way of doing that, you can looking at the Training implementation for reference

@RobotSail
Copy link
Member

@nathan-weinberg @alimaredia You have to merge it first before you can actually test it

@alimaredia
Copy link
Contributor

Ack, in the past there was another repo we used to test new runners. But we can make modifications as needed.

@mergify mergify bot added the one-approval label Aug 29, 2024
.github/workflows/e2e-nvidia-t4-x1.yml Show resolved Hide resolved
@mergify mergify bot removed the one-approval label Aug 29, 2024
@nathan-weinberg nathan-weinberg removed the request for review from RobotSail August 29, 2024 14:28
@nathan-weinberg
Copy link
Member Author

Since the Mergify config changes to require an E2E run that hasn't begun running yet, need to merge this manually

@nathan-weinberg nathan-weinberg merged commit b4ca296 into instructlab:main Aug 29, 2024
@nathan-weinberg nathan-weinberg deleted the aws-runner branch August 29, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Affects CI/CD configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert E2E job to use AWS runners

4 participants

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.