Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

mergify: add mergify configuration#114

Merged
nathan-weinberg merged 2 commits intoinstructlab:maininstructlab/eval:mainfrom
nathan-weinberg:mergifynathan-weinberg/eval:mergifyCopy head branch name to clipboard
Aug 28, 2024
Merged

mergify: add mergify configuration#114
nathan-weinberg merged 2 commits intoinstructlab:maininstructlab/eval:mainfrom
nathan-weinberg:mergifynathan-weinberg/eval:mergifyCopy head branch name to clipboard

Conversation

@nathan-weinberg
Copy link
Member

This PR does the following:

  • Adds the following Mergify automation
    • Auto-merging PRs with 2 approving reviews and successful CI
    • Auto-labeling for PRs that touch certain files
  • Updates lint action
    • Hardens several steps
    • Aligns moreso to the CLI repo

Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@nathan-weinberg nathan-weinberg requested a review from a team August 28, 2024 14:04
@nathan-weinberg nathan-weinberg linked an issue Aug 28, 2024 that may be closed by this pull request
Copy link
Contributor

@bjhargrave bjhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it looks fine.

.github/mergify.yml Outdated Show resolved Hide resolved
.github/mergify.yml Outdated Show resolved Hide resolved
.github/mergify.yml Show resolved Hide resolved
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
.github/workflows/lint.yml Show resolved Hide resolved

jobs:
spellcheck:
name: Spellcheck (en_US)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you explain this deletion?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathan-weinberg nathan-weinberg merged commit eaa977d into instructlab:main Aug 28, 2024
@nathan-weinberg nathan-weinberg deleted the mergify branch August 28, 2024 16:14
@mergify mergify bot added the CI/CD Affects CI/CD configuration label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Affects CI/CD configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introuduce merge automation via Mergify

5 participants

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.