Default to merge_system_user_message if mistral model detected#100
Merged
danmcp merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom Aug 19, 2024
Merged
Default to merge_system_user_message if mistral model detected#100danmcp merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom
danmcp merged 1 commit intoinstructlab:maininstructlab/eval:mainfrom
Conversation
Signed-off-by: Dan McPherson <dmcphers@redhat.com>
Contributor
Author
|
@JamesKunstle FYI |
| messages = conv.to_openai_api_messages() | ||
| if ( | ||
| merge_system_user_message | ||
| (merge_system_user_message or conv.name == "mistral") |
Contributor
There was a problem hiding this comment.
definitely solved for mistral (and mixtral). I wonder if there are other models that disallow system messages. If so, we could enum the names and extend that list. This patch is perfect as is though- just food for thought.
JamesKunstle
approved these changes
Aug 17, 2024
nathan-weinberg
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #97
Requires #98 to be able to function but won't cause any harm to merge before.