Proposal for new Evaluation repo#79
Proposal for new Evaluation repo#79nathan-weinberg merged 2 commits intoinstructlab:maininstructlab/dev-docs:mainfrom
Conversation
ec0937d to
dfad7d9
Compare
2678fd5 to
88ed642
Compare
russellb
left a comment
There was a problem hiding this comment.
lgtm - going to leave this open a while longer to gather more ACKs
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
eb2af00 to
1b40cb0
Compare
|
LGTM |
|
Besides the paragraph I wanted removed, this proposal in fantastic! Thanks Nathan! |
Co-authored-by: Ali Maredia <amaredia@redhat.com> Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
1133893 to
686870e
Compare
lhawthorn
left a comment
There was a problem hiding this comment.
LGTM, nice work @nathan-weinberg
|
@nathan-weinberg I believe our intent is to have proposals for new repos approved by the Oversight Committee, though I admit that if that is true it could be made more clear in our governance documentation. Arrived here via ping from @russellb to the oversight committee to review this proposal, so will let him as pinger and Oversight Committee chair opine on my statement above. |
|
@lhawthorn thanks! I assumed the approval from @russellb as a member of the Oversight Committee fulfilled that requirement, is that not the case? The repo is already created so it's a moot point now, but if more process is needed someone will need to flesh that out in the doc you linked for next time. |
|
LGTM |
Resolves #76