Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Added isStarted property to TrueTimeClient and NTPClient. #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
Loading
from

Conversation

AlexMokrushin
Copy link

What did you change and why?

Added isStarted property to TrueTimeClient and NTPClient.
If start() is called occasionally twice, app crashes on check :

precondition(self.reachability.callback == nil, "Already started")

We can avoid this crash calling start() like that:

let client = TrueTimeClient.sharedInstance
if (!client.isStarted) {
    client.start(pool: [NTP_HOST], port: NTP_PORT)
}

Potential risks introduced?

No new risks.

What tests were performed (include steps)?

Manual tests.

Checklist

  • Unit/UI tests have been written (if necessary)
  • Manually tested

This allows to avoid crash on check: precondition(self.reachability.callback == nil, "Already started")
@danielerneBIT
Copy link

Any updates about this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.