Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add component-identifier to components metadata #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

andreabedini
Copy link
Member

Fixes #1951

nix-repl> project.x86_64-linux.hsPkgs.cardano-node.components.exes.cardano-node.identifier 
{ component-id = "cardano-node:exe:cardano-node"; component-name = "cardano-node"; component-type = "exe"; name = "cardano-node"; version = "8.1.1"; }

@andreabedini andreabedini requested a review from hamishmack July 6, 2023 12:42
@andreabedini andreabedini self-assigned this Jul 6, 2023
@andreabedini
Copy link
Member Author

@hamishmack hamishmack merged commit 5b1e10c into master Jul 13, 2023
@hamishmack
Copy link
Collaborator

Nice!

andreabedini added a commit that referenced this pull request Jul 17, 2023
Rewrite mkFlakeApps, mkFlakeChecks and mkFlakePackages
hamishmack pushed a commit that referenced this pull request Jul 18, 2023
* Fix project mkFlake after #1993

Rewrite mkFlakeApps, mkFlakeChecks and mkFlakePackages

* Lint

* Use pre-existing removeRecurseForDerivations
hamishmack added a commit that referenced this pull request Jul 25, 2023
* Move custom types to haskellLib.types

Move listOfFilteringNulls, getDefaultOrNull and uniqueStr to
haskellLib.types

* Lint

* Use modules in place of passing arguments

* This is not used at all

* Formatting

* Move component options out

* Move package options out

* Move component out

* Fix bug

* Minor adjustments

Formatting

* AH!

* Fix project mkFlake after #1993

Rewrite mkFlakeApps, mkFlakeChecks and mkFlakePackages

* Lint

* Use pre-existing removeRecurseForDerivations

* ifdLevel 0

* ifdLevel 1

* ifdLevel 3

---------

Co-authored-by: Hamish Mackenzie <Hamish.K.Mackenzie@gmail.com>
@andreabedini andreabedini deleted the andrea/add-id-to-components branch August 18, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cabal-install target syntax to refer to project componets
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.