feat: FromEnv & FromEnvVar for SignetConstants types #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
reviewed
May 20, 2025
10e86c7 to
d73c20a
Compare
* feat: impl FromEnv for SignetConstants types * feat: full implementation * comments * docs, import * fix: fmt * fix: add alloy feature
Evalir
approved these changes
May 23, 2025
Evalir
reviewed
May 23, 2025
Comment on lines
+19
to
+25
| const ROLLUP_CHAIN_ID: &str = "ROLLUP_CHAIN_ID"; | ||
| const ROLLUP_BASE_FEE_RECIPIENT: &str = "ROLLUP_BASE_FEE_RECIPIENT"; | ||
| const ROLLUP_ORDERS: &str = "ROLLUP_ORDERS"; | ||
| const ROLLUP_PASSAGE: &str = "ROLLUP_PASSAGE"; | ||
| const ROLLUP_USDC: &str = "ROLLUP_USDC"; | ||
| const ROLLUP_USDT: &str = "ROLLUP_USDT"; | ||
| const ROLLUP_WBTC: &str = "ROLLUP_WBTC"; |
There was a problem hiding this comment.
not a nit for this pr necessarily, but i find we use RU and ROLLUP interchangeably on bin-base and the SDK, maybe we should consolidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl
FromEnvVarforSignetConstantstypes using theirFromStrimplementations