Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Update time_precision param values in docstring #841

Open
wants to merge 2 commits into
base: master
Choose a base branch
Loading
from

Conversation

chrominium97
Copy link

@chrominium97 chrominium97 commented Aug 3, 2020

Clearly state nanosecond and hour precision support for functions send_packet and write_points in docstring.
Nanosecond precision support was added in commits 02ddf0e and c92bb4e, but the change was not reflected to the docstring.

Closes issue #840


Contributor checklist
  • Builds are passing
  • New tests have been added (for feature additions)

Clearly state nanosecond and hour precision support for functions `send_packet` and `write_points` in docstring.
Nanosecond precision support was added in commits 02ddf0e and c92bb4e, but the change was not reflected to the docstring.
The documentation of `pandas.DataFrame.to_dict` states that "Abbreviations are allowed." for parameter `orient`. However, it induces a warning since the exact value is "records", which causes the test to fail.

References:
Documentation: https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.to_dict.html
Related pandas code: https://github.com/pandas-dev/pandas/blob/d9fff2792bf16178d4e450fe7384244e50635733/pandas/core/frame.py#L1474
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.