Adding wait time for writing a point to the DB#454
Closed
sankalpanand wants to merge 0 commit intoinfluxdata:masterinfluxdata/influxdb-java:masterfrom
Closed
Adding wait time for writing a point to the DB#454sankalpanand wants to merge 0 commit intoinfluxdata:masterinfluxdata/influxdb-java:masterfrom
sankalpanand wants to merge 0 commit intoinfluxdata:masterinfluxdata/influxdb-java:masterfrom
Conversation
efesenmaier
reviewed
Jun 7, 2018
|
|
||
| void put(final AbstractBatchEntry batchEntry, final long timeout) { | ||
| try { | ||
| this.queue.offer(batchEntry, timeout, TimeUnit.SECONDS); |
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
============================================
- Coverage 86.63% 85.46% -1.17%
- Complexity 302 303 +1
============================================
Files 20 20
Lines 1294 1314 +20
Branches 135 136 +1
============================================
+ Hits 1121 1123 +2
- Misses 113 130 +17
- Partials 60 61 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been facing a problem in production for a pretty widely used product.
BatchProcessoris currently using a BlockingQueue. There have been times when writing to this queue has blocked our main thread while writing a metric into the queue.I'm trying to address that issue through this PR by using
offer()with a timeout instead ofput. This will allow us to simply drop that data point if its taking too long instead of blocking the main thread.