Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

release 2.6#335

Merged
majst01 merged 4 commits intoinfluxdata:masterinfluxdata/influxdb-java:masterfrom
bonitoo-io:release-2.6Copy head branch name to clipboard
Jun 12, 2017
Merged

release 2.6#335
majst01 merged 4 commits intoinfluxdata:masterinfluxdata/influxdb-java:masterfrom
bonitoo-io:release-2.6Copy head branch name to clipboard

Conversation

@ivankudibal
Copy link
Contributor

Hi Stefan, the release branch for 2.6, please review.
Ivan

pom.xml Outdated
<version>7</version>
</parent>

-->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this comment, we do not need it anymore as push to maven worked.

we do not need it anymore as push to maven worked
@majst01
Copy link
Collaborator

majst01 commented Jun 12, 2017

pom.xml Outdated
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>2.2.1</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please specify most recent version. https://maven.apache.org/plugins/maven-source-plugin/ says 3.0.1

pom.xml Outdated
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>2.9.1</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, most recent is: 2.10.4 (https://maven.apache.org/plugins/maven-javadoc-plugin/)

</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, most recent is 1.6 (http://maven.apache.org/plugins/maven-gpg-plugin/)

in an attempt to make the build run succesfully
@codecov-io
Copy link

codecov-io commented Jun 12, 2017

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #335   +/-   ##
=========================================
  Coverage     79.33%   79.33%           
  Complexity      137      137           
=========================================
  Files            11       11           
  Lines           726      726           
  Branches         79       79           
=========================================
  Hits            576      576           
  Misses          109      109           
  Partials         41       41
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/impl/TimeUtil.java 64% <ø> (ø) 5 <0> (ø) ⬇️
src/main/java/org/influxdb/InfluxDB.java 100% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88a882...25f9a4a. Read the comment docs.

checked local build
gpg plugin is missing keys that would be publicly shared and used for signing
the artifacts
@majst01 majst01 merged commit 242f1e7 into influxdata:master Jun 12, 2017
@ivankudibal ivankudibal deleted the release-2.6 branch June 13, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.