Add InfluxDB.tryWrite(...) methods#287
Closed
thomaslee wants to merge 3 commits intoinfluxdata:masterinfluxdata/influxdb-java:masterfrom
Closed
Add InfluxDB.tryWrite(...) methods#287thomaslee wants to merge 3 commits intoinfluxdata:masterinfluxdata/influxdb-java:masterfrom
thomaslee wants to merge 3 commits intoinfluxdata:masterinfluxdata/influxdb-java:masterfrom
Conversation
Author
|
As an aside: I had to modify maven-compiler-plugin in the POM to build against Java 1.8 due to the use of |
Collaborator
|
Can you please check if your requirements are solved with: #319, if yes please close this PR. |
Collaborator
|
Im closing this because there was no response for a long time, @thomaslee please reopen if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently a change was introduced to optionally bound the actions queue in
BatchProcessor. That's a great improvement, but the blocking semantics ofqueue.put(...)aren't always desirable.We (@neeveresearch) wanted to attempt to enqueue a point in the batch. If the queue is full, we then wanted to simply drop the data and continue on with other more important things. Due to the blocking semantics, we ended up having to roll our own batching.
This PR introduces
InfluxDB.tryWrite(...)methods that have similar semantics toBlockingQueue.offer(...)when batching is enabled: if the BatchProcessor's action queue is full, return false and leave it to the caller to determine what to do next. If batching is not enabled, it's equivalent to the semantics of a normal write (albeit we returntrue).This change should be fully backward compatible with earlier releases at the source & bytecode level. I also modified the BatchProcessorTest to clean up threads that might otherwise leak.