Update outdated ACL management #7136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
785aa64 to
923de7d
Compare
180130c to
fa98650
Compare
fa98650 to
42a6b80
Compare
ThiefMaster
approved these changes
Dec 8, 2025
ThiefMaster
reviewed
Dec 10, 2025
| if self.entry.is_page and self.entry.page.html != form.html.data: | ||
| changes['html'] = (self.entry.page.html, form.html.data) | ||
| self.entry.page.html = form.html.data | ||
| update_read_permissions(self.entry, form) |
Member
There was a problem hiding this comment.
This broke editing builtin entries since these do not have an ACL. Fixed in 2a4c888
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about streamlining ACL management for
ProtectionMixinclasses (Attachment,AttachmentFolder,MenuEntry).Why is it needed?
Despite the management methods exist (
update_principal,remove_principal), they are used only in tests and not in production code. The principals are updated using the usual populate-by-form methods resultingsignals.acl.entry_changedis not called, ACL changes are not logged in user log.Solution
A new function
update_read_permissionsis added toindico.core.permissionsmodule. Its signature intentionally the same as forupdate_permissionswhich operates onProtectionManagerMixinpermissions. Seemingly these functions would be worth further refactoring but I didn't want to go too far in this PR. Please let me know if you think otherwise.