-
Notifications
You must be signed in to change notification settings - Fork 509
Improve Booking Linking #6846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Booking Linking #6846
Conversation
|
@ThiefMaster ready for review! |
dbea03b to
1177eb2
Compare
|
Works much better now, thanks! What do you think about somehow (red? some icon?) highlighting the "Booked for ..." if the booking cannot be linked because it's for someone else. |
If I'd have to say one thing I'm not good at, it'd be UI. A red-ish color is fine for me, but simply because it does the job and it's the easiest to implement. But here's your call, I'd say. |
|
Hrm, not sure. You get to linking mode from your event's management area, so it should be very clear what you're linking. It's also shown in the linking mode bar. The prompt is mainly so you don't accidentally click thinking there's another dialog or whatever before the link is actually created. (in any case it'd probably trivial to do since the information is in the state) |
eee3400 to
6affcdd
Compare
98fa35b to
d23262e
Compare
b942ed6 to
0af2b36
Compare
For +- 1 week buttons, pass earlier/later and increment them client-side. Do not try to merge data, the query is cheap enough so we can just re-fetch for the whole range and replace the data already in the store.
0af2b36 to
c2d3570
Compare
This was due to a toggle in there which is now gone again
The initial data is part of the state and should always be there
Building params separately instead of combining them in multiple steps makes this easier to read and understand


Closes #6811
Closes #6568
Description
This PR:
Screenshots