Make main section title a bypass block title #6726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d86bfde to
5bc27ba
Compare
Member
|
LGTM! In cases of conference events, the main conference page does not have such a title though. Likewise for "lecture" and "meeting" events. I think this solves it, but for lectures/meetings this includes the full event area including the title, location, etc. (I guess that's also "main content"?). Feel free to adjust or lmk if you agree that it should be done like this, then I can commit it myself and add it here before merging: diff --git a/indico/modules/events/templates/display/conference.html b/indico/modules/events/templates/display/conference.html
index 5566af63a2..7e8887bee6 100644
--- a/indico/modules/events/templates/display/conference.html
+++ b/indico/modules/events/templates/display/conference.html
@@ -3,7 +3,7 @@
{% from 'attachments/_attachments.html' import render_attachments %}
{% block content %}
- <div class="conferenceDetails">
+ <div class="conferenceDetails" id="main-content" data-bypass-target="{% trans %}Skip to main content{% endtrans %}">
<div itemprop="description" class="description js-mathjax editor-output">
{{ event.description }}
</div>
diff --git a/indico/modules/events/templates/display/indico/lecture.html b/indico/modules/events/templates/display/indico/lecture.html
index 5c0e67a524..523b852028 100644
--- a/indico/modules/events/templates/display/indico/lecture.html
+++ b/indico/modules/events/templates/display/indico/lecture.html
@@ -11,7 +11,9 @@
or event.contact_emails or event.contact_phones
or (event.references and event.type == 'meeting') or hook_event_header %}
-<div class="event-wrapper {% block event_classes %}{% endblock %}">
+<div class="event-wrapper {% block event_classes %}{% endblock %}"
+ id="main-content"
+ data-bypass-target="{% trans %}Skip to main content{% endtrans %}">
{% block header %}
<div class="event-header event-header-lecture {%- if not has_subheader %} round-bottom-corners{% endif %}">
<div class="event-title">
diff --git a/indico/modules/events/templates/display/indico/meeting.html b/indico/modules/events/templates/display/indico/meeting.html
index 7d6cc948c7..fad91783a7 100644
--- a/indico/modules/events/templates/display/indico/meeting.html
+++ b/indico/modules/events/templates/display/indico/meeting.html
@@ -12,7 +12,9 @@
or event.contact_emails or event.contact_phones
or (event.references and event.type == 'meeting') or hook_event_header %}
-<div class="event-wrapper {% block event_classes %}{% endblock %}">
+<div class="event-wrapper {% block event_classes %}{% endblock %}"
+ id="main-content"
+ data-bypass-target="{% trans %}Skip to main content{% endtrans %}">
{% block header %}
<div class="event-header {%- if not has_subheader %} round-bottom-corners{% endif %}">
<div class="event-title"> |
Collaborator
Author
|
LGTM. If there's a need to adjust that later, we can do it easily. |
5bc27ba to
59d6fbe
Compare
- Affects base layout and any page using it - Reserves the `main-content` id for the H2 heading in the layout template - Can be overridden by blanking out the bypass_target block
59d6fbe to
54dec71
Compare
ThiefMaster
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main-contentid for the H2 heading in the layout templateThe original intent was to target event pages only, but unless this breaks other pages somewhere, it's an even better solution from the accessibility standpoint.