Get rid of marshmallow-enum
#6703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Just a heads up: your branch is out of date with what is on Also, don't forget to add an entry in the changelog! :) |
added 2 commits
January 20, 2025 15:33
Enums have been supported by Marshmallow since version 3.18.0
0c093ae to
c80de7e
Compare
tomasr8
reviewed
Jan 20, 2025
c80de7e to
898c66c
Compare
Member
|
@federez-tba if you can, try to avoid force-pushing (we'll squash the commits anyway) It just makes it more difficult to see what has changed since the last review ;) |
tomasr8
approved these changes
Jan 21, 2025
Member
|
Thanks @federez-tba! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
marshmallow_enum.EnumFieldwithmarshallow.fields.Enum.Remove the
marshmallow-enumdependency.Resolves #6701.