Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@micsucmed
Copy link
Contributor

closes #6331

@micsucmed micsucmed force-pushed the receipt-files-export branch 2 times, most recently from bf9c9af to 14224e1 Compare May 15, 2024 14:19
@ThiefMaster ThiefMaster added this to the v3.3 milestone May 15, 2024
indico/modules/users/export.py Show resolved Hide resolved
@micsucmed micsucmed marked this pull request as draft May 15, 2024 15:04
indico/modules/users/export_schemas.py Outdated Show resolved Hide resolved
@ThiefMaster ThiefMaster force-pushed the receipt-files-export branch from a0e5e66 to b7a5ca6 Compare May 23, 2024 09:50
@ThiefMaster
Copy link
Member

For the failing tests:

  • I suggest skipping the url since including token URLs (which has an expiry) in the export doesn't make lots of sense
  • The file paths also have a reference to the IDs, so currently there's another failure in the tests when you just run some tests, e.g. using pytest indico/modules/users/export_schemas_test.py because then less IDs have been consumed (we do not commit anything during/between tests, but auto-incrementing serial IDs are consumed regardless).

I just pushed commits fixing both these issues.

@micsucmed micsucmed marked this pull request as ready for review May 23, 2024 15:02
@ThiefMaster ThiefMaster force-pushed the receipt-files-export branch from 25c3f8a to a32910d Compare May 23, 2024 15:41
indico/modules/users/export_schemas.py Outdated Show resolved Hide resolved
indico/modules/users/export.py Outdated Show resolved Hide resolved
indico/modules/users/export_schemas.py Outdated Show resolved Hide resolved
@ThiefMaster ThiefMaster force-pushed the receipt-files-export branch from 5cae6ab to 9b48624 Compare June 4, 2024 15:04
@ThiefMaster ThiefMaster force-pushed the receipt-files-export branch from 9b48624 to 625885e Compare June 4, 2024 15:16
@ThiefMaster ThiefMaster force-pushed the receipt-files-export branch from 625885e to 6df52e8 Compare June 4, 2024 15:18
@ThiefMaster ThiefMaster enabled auto-merge (squash) June 4, 2024 15:20
@ThiefMaster ThiefMaster merged commit ee55c87 into indico:master Jun 4, 2024
micsucmed added a commit to micsucmed/indico that referenced this pull request Jun 11, 2024
@micsucmed micsucmed deleted the receipt-files-export branch September 26, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Receipt files missing from data export

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.