Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@GovernmentPlates
Copy link
Member

@GovernmentPlates GovernmentPlates commented Dec 1, 2023

Closes: #6075

This PR adds the ability to add events directly to Outlook as well as introduces improvements to the social widget:

  • Remove Facebook Like and Google+ sharing options
  • Replace old social icon with a generic share icon (from icomoon)
  • General UI tweaks

Preview:
image
image

indico/modules/events/client/js/util/social.js Outdated Show resolved Hide resolved
indico/modules/events/templates/footer.html Outdated Show resolved Hide resolved
@GovernmentPlates GovernmentPlates force-pushed the Outlook-Social-Widget-6075 branch 2 times, most recently from fcc2d8e to cdae0b6 Compare December 1, 2023 09:34
@ThiefMaster ThiefMaster force-pushed the Outlook-Social-Widget-6075 branch from cdae0b6 to ba09e21 Compare December 4, 2023 00:44
indico/modules/events/client/js/util/social.js Outdated Show resolved Hide resolved
indico/modules/events/templates/footer.html Outdated Show resolved Hide resolved
@ThiefMaster
Copy link
Member

I think this widget deserves a bigger makeover at some point (it still doesn't look super amazing).

Anyway, for the upcoming release your cleanups are nice and the Outlook share will certainly be appreciated -> I'm good to merge it tomorrow once the comments are resolved.

@GovernmentPlates GovernmentPlates force-pushed the Outlook-Social-Widget-6075 branch from ba09e21 to 1e294ae Compare December 4, 2023 10:58
CHANGES.rst Outdated Show resolved Hide resolved
@GovernmentPlates GovernmentPlates force-pushed the Outlook-Social-Widget-6075 branch 3 times, most recently from 398e0d1 to c9599b2 Compare December 4, 2023 15:04
Also improve social widget
Replace the Tweet button with a script-free button
@GovernmentPlates GovernmentPlates force-pushed the Outlook-Social-Widget-6075 branch from c9599b2 to 3944b57 Compare December 4, 2023 22:05
Darken the sharing icon (so that it doesn't disappear on conference pages - visibility), Improve text and button layout inside the pop-up (readability)
@GovernmentPlates GovernmentPlates force-pushed the Outlook-Social-Widget-6075 branch from 3944b57 to 3e40caa Compare December 4, 2023 22:19
@ThiefMaster ThiefMaster enabled auto-merge (squash) December 4, 2023 22:43
@ThiefMaster ThiefMaster added this to the v3.3 milestone Dec 4, 2023
@ThiefMaster ThiefMaster merged commit a85050b into indico:master Dec 4, 2023
@ThiefMaster ThiefMaster deleted the Outlook-Social-Widget-6075 branch December 4, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

See if we can have an "add to outlook" link like we have for google in the social widget

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.