Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Implement admin override keyboard shortcut #5909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ThiefMaster merged 2 commits into from
Aug 30, 2023
Merged

Implement admin override keyboard shortcut #5909

ThiefMaster merged 2 commits into from
Aug 30, 2023

Conversation

@GovernmentPlates
Copy link
Member

@GovernmentPlates GovernmentPlates commented Aug 28, 2023 •
edited
Loading

This PR adds a Ctrl + A keyboard shortcut for toggling the RB admin override.

Preview:
image

ThiefMaster
ThiefMaster reviewed Aug 28, 2023
View reviewed changes
indico/modules/rb/client/js/components/AdminOverrideBar.jsx Show resolved Hide resolved
indico/modules/rb/client/js/components/AdminOverrideBar.jsx Outdated Show resolved Hide resolved
@GovernmentPlates GovernmentPlates force-pushed the Misc-Admin-Shortcut-Toggle branch 4 times, most recently from f017b8e to 56125d7 Compare August 29, 2023 08:02
@ThiefMaster ThiefMaster force-pushed the Misc-Admin-Shortcut-Toggle branch from 56125d7 to 28919ff Compare August 30, 2023 10:39
@ThiefMaster
Use CTRL+SHIFT+A for admin o verride
f7f7020 
This avoids breaking CTRL+A select-all w/o explicitly changign behavior
when the originating element is a text-like input field
@ThiefMaster ThiefMaster force-pushed the Misc-Admin-Shortcut-Toggle branch from 28919ff to f7f7020 Compare August 30, 2023 10:40
@ThiefMaster ThiefMaster enabled auto-merge (squash) August 30, 2023 10:41
@ThiefMaster ThiefMaster added this to the v3.3 milestone Aug 30, 2023
@ThiefMaster ThiefMaster merged commit 5eb99ae into indico:master Aug 30, 2023
@ThiefMaster ThiefMaster deleted the Misc-Admin-Shortcut-Toggle branch August 30, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThiefMaster ThiefMaster ThiefMaster approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.3

Development

Successfully merging this pull request may close these issues.

2 participants

@GovernmentPlates @ThiefMaster
Morty Proxy This is a proxified and sanitized view of the page, visit original site.