Add header check to middleware#16
Open
EcoGabe wants to merge 1 commit intoin2code-de:mainin2code-de/instagram:mainfrom
EcoGabe:fix/add-header-check-to-middlewareEcoGabe/instagram:fix/add-header-check-to-middlewareCopy head branch name to clipboard
Open
Add header check to middleware#16EcoGabe wants to merge 1 commit intoin2code-de:mainin2code-de/instagram:mainfrom EcoGabe:fix/add-header-check-to-middlewareEcoGabe/instagram:fix/add-header-check-to-middlewareCopy head branch name to clipboard
EcoGabe wants to merge 1 commit intoin2code-de:mainin2code-de/instagram:mainfrom
EcoGabe:fix/add-header-check-to-middlewareEcoGabe/instagram:fix/add-header-check-to-middlewareCopy head branch name to clipboard
Conversation
| $code = $request->getQueryParams()['code']; | ||
| if (strlen($code) > 8) { | ||
| return true; | ||
| if (in_array('https://l.instagram.com/', $request->getHeader('referer'))) { |
There was a problem hiding this comment.
In my case the referer header contains the App return URL and not l.instagram.com - not sure if instagram changed anything in the way they redirect. With this check, no authentication code can be obtained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current way the request is being checked, this middleware will clash with any service using a parameter named "code" as a part of their OAuth flow. Checking if the
refererishttps://l.instagram.com/will avoid this problem.