Provide default type to first() and last() #1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
rgbkrk
approved these changes
Jun 13, 2019
|
If I could merge this, I would. |
|
This is the right thing. thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
new OrderedSet().first()gives a compiler error, because theNSVtype is not known.new OrderedSet<V>('a string').first()returns typeV | stringYou need to explicitly provide the type to
first().Intuitively you would pass type
V:new OrderedSet().first<V>()returns typeV, although it can returnundefinedThe correct way would be:
new OrderedSet().first<undefined>()ornew OrderedSet().first(undefined), which would return typeV | undefinedAfter
new OrderedSet<V>().first()returns typeV | undefinednew OrderedSet<V>('a string').first()returns typeV | stringLess likely to make misstakes.
Less typing in the common case when you want
undefinedwhen there is no first value.