eslint + prettier - jshint #1101
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
I didn't modify code to not create merge conflicts. Preferred eslint rules marked as Run |
pages/src/.eslintrc
Outdated
| "ecmaVersion": 6, | ||
| "sourceType": "script" | ||
| } | ||
| } |
There was a problem hiding this comment.
won't this file override the parent eslintrc and remove the custom rules you set up? If the only difference is adding env.browser then I think it's safe to merge in
There was a problem hiding this comment.
Of course it's safe 👍 check http://eslint.org/docs/user-guide/configuring#configuration-cascading-and-hierarchy
|
This is awesome, nice work |
|
Do not forget to |
|
I'd rather not include all the warnings - from past usage I've found warnings get ignored and just pile up over time. I think the eslintrc should either turn things off or make them errors with no need for a "lint:warn" npm script Some examples of rules that are broken pervasively in this codebase and are safe to turn off:
|
…sign` eslint rules.
Done.
Agree, I kept "worthy" rules as a |
commit 324c2795417bc908c92dbf1b6327e15a4daaf4bf
Author: Lee Byron <lee@leebyron.com>
Date: Tue Mar 7 21:14:34 2017 -0800
Convert warns to off/error, fix sources
commit 498c0c654bbfbbf70d951164c1c7a38a3a750d01
Merge: b20892d 357ee52
Author: Lee Byron <lee@leebyron.com>
Date: Tue Mar 7 20:36:44 2017 -0800
Merge branch 'eslint' of https://github.com/umidbekkarimov/immutable-js into umidbekkarimov-eslint
commit 357ee52
Author: Umidbek Karimov <uma.karimov@gmail.com>
Date: Tue Mar 7 23:06:17 2017 +0400
Regenerage `yarn.lock` file.
commit d2bcb51
Merge: f3d4115 82c7b87
Author: Umidbek Karimov <uma.karimov@gmail.com>
Date: Tue Mar 7 23:03:54 2017 +0400
Merge branch 'master' into eslint
commit f3d4115
Author: Umidbek Karimov <uma.karimov@gmail.com>
Date: Tue Mar 7 22:51:43 2017 +0400
Turn off `vars-on-top`, `no-var`, `consistent-return`, `no-param-reassign` eslint rules.
commit dbc2820
Author: Umidbek Karimov <uma.karimov@gmail.com>
Date: Tue Mar 7 17:55:38 2017 +0400
eslint + prettier - jshint
|
Closing this from bb2fbf1 |
See #742, #1096