Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Immutable Map, updateIn and Flow type checking #1586

Copy link
Copy link
Open
@zaufi

Description

@zaufi
Issue body actions

The minimal example:

//@flow
import {Map} from 'immutable';

type Key$Lower = 'application' | 'status' | 'hostname' | 'timestamp';
type Map$Lower = Map<
    Key$Lower
  , number | string
  >;

type Key$Upper = 'updates';
type Map$Upper = Map<Key$Upper, Map$Lower>;

function update_ts(timestamp: number): number
{
    console.log('timestamp=%o', timestamp);
    return timestamp;
}
function foo(current: Map$Upper)
{
    let next = current.updateIn(
        ['updates', 'timestamp']
      , 0
      , t => update_ts(t)
      );
    console.log('next=%o', next);
}

Cause the following error:

 Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ src/foo.js:25:32

Cannot call update_ts with t bound to timestamp because string [1] is incompatible with number [2].

    src/foo.js
[2]  15│ function update_ts(timestamp: number): number
        :
    22│     let next = current.updateIn(
    23│         ['updates', 'timestamp']
    24│       , 0
    25│       , t => update_ts(t)
    26│       );
    27│     console.log('next=%o', next);
    28│ }

    node_modules/immutable/dist/immutable.js.flow
[1] 695│   updateIn<NSV, K2: $KeyOf<V>, S: $ValOf<V, K2>>(keyPath: [K, K2], notSetValue: NSV, updater: (value: $ValOf<V, K2> | NSV) => S): this;

If that is not a bug, I would really appreciate an explanation of this behavior %)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.