Update rust to 1.89 #883
Merged
Update rust to 1.89 #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70956a2 to
d96595a
Compare
ludfjig
reviewed
Sep 11, 2025
jprendes
reviewed
Sep 11, 2025
d96595a to
fcd6a4c
Compare
jsturtevant
reviewed
Sep 11, 2025
ludfjig
reviewed
Sep 12, 2025
ludfjig
previously approved these changes
Sep 12, 2025
Contributor
ludfjig
left a comment
There was a problem hiding this comment.
LGTM except the one comment I put
nit: we have a bunch of other allow specified for the entire flatbuffer mod in src/hyperlight_common/src/lib.rs. Maybe consider moving this allow over there so it won't be removed next time we regenerate these.
fcd6a4c to
cba5506
Compare
jsturtevant
approved these changes
Sep 15, 2025
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
cba5506 to
6a68f85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.