Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Bring back HostFunctionDefinitions Region #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danbugs merged 2 commits into from
Jun 12, 2025
Merged

Bring back HostFunctionDefinitions Region #600

danbugs merged 2 commits into from
Jun 12, 2025

Conversation

@danbugs
Copy link
Contributor

@danbugs danbugs commented Jun 11, 2025

This memory region removed because it wasn't used by Hyperlight Core, but it is used for type introspection in Hyperlight Wasm when running Wasm modules, so this PR reverts the work of #453.

@danbugs danbugs added the kind/refactor For PRs that restructure or remove code without adding new functionality. label Jun 11, 2025
@danbugs danbugs force-pushed the revert-pr-453 branch 2 times, most recently from f949a1c to d27a2e5 Compare June 11, 2025 05:22
jprendes
jprendes reviewed Jun 11, 2025
View reviewed changes
src/hyperlight_guest/src/host_functions.rs Outdated Show resolved Hide resolved
jprendes
jprendes reviewed Jun 11, 2025
View reviewed changes
src/hyperlight_guest/src/host_functions.rs Outdated Show resolved Hide resolved
jprendes
jprendes reviewed Jun 11, 2025
View reviewed changes
src/hyperlight_guest/src/host_functions.rs Outdated Show resolved Hide resolved
@danbugs danbugs force-pushed the revert-pr-453 branch 5 times, most recently from eea95ae to db43b0b Compare June 12, 2025 15:45
jprendes
jprendes approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works.

danbugs added 2 commits June 12, 2025 16:08
@danbugs
Revert "[host/{mem,func},guest/host_functions,common/peb] Removed Hos…
b101395 
…tFunctionDefinitions memory region"

This reverts commit 1d938f2.

Signed-off-by: danbugs <danilochiarlone@gmail.com>
@danbugs
Revert "[flatbuffer] updated flatbuffer schema to remove host_functio…
1c7fc4d 
…n_*"

This reverts commit af6c1a9.

Signed-off-by: danbugs <danilochiarlone@gmail.com>
@danbugs danbugs merged commit 1c7fc4d into hyperlight-dev:main Jun 12, 2025
32 checks passed
@jsturtevant jsturtevant mentioned this pull request Sep 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jprendes jprendes jprendes approved these changes

@ludfjig ludfjig Awaiting requested review from ludfjig ludfjig is a code owner

@dblnz dblnz Awaiting requested review from dblnz dblnz is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically is a code owner

@marosset marosset Awaiting requested review from marosset marosset is a code owner

@simongdavies simongdavies Awaiting requested review from simongdavies simongdavies is a code owner

Assignees

No one assigned

Labels

kind/refactor For PRs that restructure or remove code without adding new functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danbugs @jprendes
Morty Proxy This is a proxified and sanitized view of the page, visit original site.