Add explicit license metadata for Python bindings#1976
Add explicit license metadata for Python bindings#1976julia-thorn wants to merge 8 commits intohuggingface:mainhuggingface/tokenizers:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Pull request overview
Adds explicit Apache-2.0 license metadata for the Python bindings so that installed artifacts have consistently discoverable license information for compliance tooling.
Changes:
- Set PEP 639 license metadata in
bindings/python/pyproject.toml(license+license-files) and stop treating license as a dynamic field. - Add an Apache 2.0
LICENSEfile underbindings/pythonfor inclusion in built artifacts. - Declare
license = "Apache-2.0"in the Rustbindings/python/Cargo.tomlpackage metadata.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| bindings/python/pyproject.toml | Adds explicit PEP 639 license metadata for Python package builds |
| bindings/python/LICENSE | Adds license text intended to be shipped with distributions |
| bindings/python/Cargo.toml | Adds SPDX license metadata for the Rust crate powering the Python extension |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@ArthurZucker Ready for re-review, thanks! |
|
@ArthurZucker bumping this PR, thank you! |
|
@ArthurZucker ready for review, thank you! |
Description
Set explicit Apache-2.0 license metadata and include a LICENSE file in built distributions so package metadata is consistently discoverable.
Motivation and Context
Compliance tooling reads installed artifact metadata. Without explicit license fields/files, packages can be reported as having no detectable license even when the repo is properly licensed.