Fixes null commit date #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7105c19 to
21b6130
Compare
21b6130 to
938603f
Compare
bitwiseman
reviewed
Nov 30, 2020
| @@ -0,0 +1,41 @@ | ||
| { |
There was a problem hiding this comment.
You might need to re-record. I don't see any use of this in the test.
bitwiseman
reviewed
Nov 30, 2020
| GHRepository repo = gitHub.getRepository("hub4j/github-api"); | ||
| GHCommit commit = repo.getCommit("ed4f9c8176866977677c99ac9668a8ce10231bc8"); | ||
|
|
||
| assertNotNull(commit.getCommitShortInfo().getAuthoredDate()); |
There was a problem hiding this comment.
Please check for more than just not null. There is a known expected value that isn't going to change over time. Check for the correct value and that the two methods return the same value.
bitwiseman
requested changes
Nov 30, 2020
There was a problem hiding this comment.
Thanks for contributing!
Minor change to test data.
Also, there are other tests that return commit info. Please add some checks to other tests to verify this fix works on exiting tests and data.
|
@lower-case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #883
Method
GHAuthor.getDate()was giving null because thedatefield was overridden in deprecated GHAuthor class but the field was populated only inGitUserclass.Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn clean compilelocally. This may reformat your code, commit those changes.mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.When creating a PR: