Fix GHTeam#remove(GHUser) and add tests #1438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
commented
Apr 21, 2022
Codecov Report
@@ Coverage Diff @@
## main #1438 +/- ##
============================================
+ Coverage 78.65% 78.77% +0.12%
- Complexity 2097 2100 +3
============================================
Files 201 201
Lines 6389 6390 +1
Branches 359 359
============================================
+ Hits 5025 5034 +9
+ Misses 1157 1149 -8
Partials 207 207
Continue to review full report at Codecov.
|
e4145dd to
d870d21
Compare
|
Thanks for the quick release @bitwiseman ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I included the original commit of #1437 with the original author (just reworded the commit message for more clarity).
My advice would be to release something right away as this could be considered as a security issue given we are not removing people from teams appropriately.
Note that it was broken anyway since GH retired the old Teams API.