Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add mapping for from/to fields in issue rename event #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

t0m4uk1991
Copy link
Contributor

Description

Issue rename event do not include information about previous(old) name.

According to the docs response contain rename object with from/to properties for previous/new name. Mappings for this fields were added in scope of this PR.

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #1175 (2c06ed0) into main (3ced4fc) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1175      +/-   ##
============================================
+ Coverage     73.47%   73.52%   +0.05%     
- Complexity     1839     1844       +5     
============================================
  Files           185      186       +1     
  Lines          6148     6154       +6     
  Branches        367      367              
============================================
+ Hits           4517     4525       +8     
+ Misses         1410     1408       -2     
  Partials        221      221              
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/GHIssueEvent.java 56.00% <100.00%> (+1.83%) ⬆️
...rc/main/java/org/kohsuke/github/GHIssueRename.java 100.00% <100.00%> (ø)
src/main/java/org/kohsuke/github/GHIssue.java 71.62% <0.00%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ced4fc...2c06ed0. Read the comment docs.

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR.
High quality with tests and comments.

@bitwiseman bitwiseman merged commit 05e63f5 into hub4j:main Jun 10, 2021
@t0m4uk1991 t0m4uk1991 deleted the issue_rename_event_add_from_to_metadata branch July 23, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.