Add support for repository visibility #1074
Conversation
|
I wasn't able to add a JUnit test for "internal" because it's exclusive to GitHub Enterprise, but I did do some manual testing against an enterprise instance:
|
|
Also, if I can get access to |
| private GHVisibility visibility; | ||
|
|
There was a problem hiding this comment.
We were just having a discussion on another thread as to how to handle enums like this. We settled on a storing them as String and converting when requested to avoid throwing exceptions if new values are ever added.
See b8f00bc
| @@ -249,6 +249,27 @@ public void testUpdateRepository() throws Exception { | ||
| assertThat(redux.getDescription(), equalTo(updatedDescription)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetRepositoryWithVisibility() throws IOException { |
There was a problem hiding this comment.
Definitely want to test the INTERNAL value as well. If you can create a test for it and then manually modify the data , that would be great. After recording, have the test use snapshotNotAllowed(); so no one accidentally deletes that data.
|
Thanks @bitwiseman, should be ready for another look. |
b3eb76f to
08eeea6
Compare
|
Hm, I have no idea what I did to make this break. I'll look at it tomorrow. |
08eeea6 to
99f192d
Compare
|
I think this was the issue: https://github.com/hub4j/github-api/pull/1075/files#diff-a57ffc6640b7868f12be28cd63c1587ecbcb58c5551129d51838d8887059139dL61-R67 That change switched from importing all previews to importing specific ones, so I just needed to add NEBULA to the list. |
Description
Adds support for the repository "visibility" field - "public" or "private," plus "internal" for Enterprise
Fixes #932
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.When creating a PR: