Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

WARNING [com.squareup.okhttp.OkHttpClient] (OkHttp ConnectionPool) A connection to https://api.github.com/ was leaked. Did you forget to close a response body? #997

Copy link
Copy link
Closed
@soul2zimate

Description

@soul2zimate
Issue body actions

WARNING [com.squareup.okhttp.OkHttpClient] (OkHttp ConnectionPool) A connection to https://api.github.com/ was leaked. Did you forget to close a response body?

I am using version 1.116. I sometimes see this warning message in my server log, there is no real occurrence pattern. I am not sure why that happened, but it seems it relates to bad network connection.

In my code, I have a static GitHub instance and use it periodically to communicate with Github.

    protected static GitHub github;

...
// create the github instance from initialization like below 
...

    github = new GitHubBuilder()
            .withOAuthToken(config.getPassword(), config.getUsername())
            .withConnector(new OkHttpConnector(new OkUrlFactory(new OkHttpClient().setCache(cache))))
            .build();

I can see similar message mentioned in a previous pull request #346 on Feb 23, 2017 trying to ignore the warning from okhttp.

Does this really a harmful messages ? How should I prevent this in github-api since I don't use okhttp directly.

Thank you.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.