Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9b1096e

Browse filesBrowse files
committed
Avoid O(n^2) string concatenation in concatCharacterTokens()
1 parent 8f7f9f0 commit 9b1096e
Copy full SHA for 9b1096e

File tree

1 file changed

+7
-10
lines changed
Filter options

1 file changed

+7
-10
lines changed

‎html5lib/treewalkers/__init__.py

Copy file name to clipboardExpand all lines: html5lib/treewalkers/__init__.py
+7-10Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -62,21 +62,18 @@ def getTreeWalker(treeType, implementation=None, **kwargs):
6262

6363

6464
def concatenateCharacterTokens(tokens):
65-
charactersToken = None
65+
pendingCharacters = []
6666
for token in tokens:
6767
type = token["type"]
6868
if type in ("Characters", "SpaceCharacters"):
69-
if charactersToken is None:
70-
charactersToken = {"type": "Characters", "data": token["data"]}
71-
else:
72-
charactersToken["data"] += token["data"]
69+
pendingCharacters.append(token["data"])
7370
else:
74-
if charactersToken is not None:
75-
yield charactersToken
76-
charactersToken = None
71+
if pendingCharacters:
72+
yield {"type": "Characters", "data": "".join(pendingCharacters)}
73+
pendingCharacters = []
7774
yield token
78-
if charactersToken is not None:
79-
yield charactersToken
75+
if pendingCharacters:
76+
yield {"type": "Characters", "data": "".join(pendingCharacters)}
8077

8178

8279
def pprint(tokens):

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.