Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[hotfix] Fix no attribute issue when evaluation dataset is not provided.#6343

Merged
TongLi3701 merged 1 commit intogrpo-latesthpcaitech/ColossalAI:grpo-latestfrom
hotfox/train-without-evalhpcaitech/ColossalAI:hotfox/train-without-evalCopy head branch name to clipboard
Jun 10, 2025
Merged

[hotfix] Fix no attribute issue when evaluation dataset is not provided.#6343
TongLi3701 merged 1 commit intogrpo-latesthpcaitech/ColossalAI:grpo-latestfrom
hotfox/train-without-evalhpcaitech/ColossalAI:hotfox/train-without-evalCopy head branch name to clipboard

Conversation

@TongLi3701
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@TongLi3701 TongLi3701 requested a review from a team as a code owner June 10, 2025 05:17
@TongLi3701 TongLi3701 changed the title [hotfix] fix none type issue when evaluation dataset is not provided. [hotfix] Fix no attribute issue when evaluation dataset is not provided. Jun 10, 2025
@TongLi3701 TongLi3701 merged commit bb6f5d9 into grpo-latest Jun 10, 2025
5 checks passed
@TongLi3701 TongLi3701 deleted the hotfox/train-without-eval branch June 10, 2025 05:53
YeAnbang pushed a commit that referenced this pull request Aug 5, 2025
Co-authored-by: Tong Li <tong.li35271158@gmail.com>
YeAnbang pushed a commit that referenced this pull request Aug 5, 2025
Co-authored-by: Tong Li <tong.li35271158@gmail.com>
YeAnbang pushed a commit that referenced this pull request Aug 5, 2025
Co-authored-by: Tong Li <tong.li35271158@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.