Display Zigbee Connection on device page #27380
Conversation
|
I'm not familiar with the frontend project, so do not know how to test this, even failed to test this manually. But maybe the change is small enough so we can merge it anyways. |
| protected _getAddresses() { | ||
| return this.device.connections.filter( | ||
| (conn) => conn[0] === "mac" || conn[0] === "bluetooth" | ||
| (conn) => conn[0] === "mac" || conn[0] === "bluetooth" || conn[0] === "zigbee" |
There was a problem hiding this comment.
While rendering, we check for the type and only handle bluetooth and mac for now, so nothing will be done with this.
There was a problem hiding this comment.
Also, is zigbee even used as a connection type here?
There was a problem hiding this comment.
we check for the type and only handle bluetooth and mac for now
No, it's handled in the else case, but I had to have another look as well:
: html`${type === "mac" ? "MAC" : titleCase(type)}:
${value.toUpperCase()}`}
I wanted to use it in my intestration and was wondering why it did not show up. It is used for e.g. ZHA, WEMO and Decons devices, but for ZHA it is also rendered in the additional Zigbee Info part.
There was a problem hiding this comment.
So for ZHA we are now showing it twice?
There was a problem hiding this comment.
It would look like this:
There was a problem hiding this comment.
Can we then remove it from the ZHA zigbee info?
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Proposed change
This makes ZigBee device connection appear on the device page as for BLE and MAC.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: