Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

TimoPtr
Copy link
Member

@TimoPtr TimoPtr commented Oct 16, 2025

Summary

Our screenshot tests were limited because the default configuration was using a too small parameter for the size of the Heap. It has been fixed by Google but not yet published, since we are hitting the limit again even after limiting the numbers of screenshots, we need a way around because we are adding more and more screenshots and we can't disable them all the time.

I looked at how they've fixed the issue https://cs.android.com/android-studio/platform/tools/base/+/435cc74d31620583c8d561b00b83ac637b6fb881:preview/screenshot/screenshot-test-gradle-plugin/src/main/java/com/android/compose/screenshot/PreviewScreenshotGradlePlugin.kt and replicated in our repo.

I also tested locally how much RAM we need and bellow 3g we have the issue once I've enabled back all the screenshots for the onboarding.

Copy link
Contributor

github-actions bot commented Oct 16, 2025

Test Results

 91 files   91 suites   10m 30s ⏱️
621 tests 621 ✅ 0 💤 0 ❌
637 runs  637 ✅ 0 💤 0 ❌

Results for commit 2642fa9.

♻️ This comment has been updated with latest results.

Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Hopefully it comes to a release soon.

@TimoPtr TimoPtr merged commit 9347039 into main Oct 16, 2025
60 of 70 checks passed
@TimoPtr TimoPtr deleted the fix/tweak-ram-for-screenshots-testing branch October 16, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.